Build: Use major.minor versions in runtime-deps baselines#16233
Open
kevinjqliu wants to merge 2 commits into
Open
Build: Use major.minor versions in runtime-deps baselines#16233kevinjqliu wants to merge 2 commits into
kevinjqliu wants to merge 2 commits into
Conversation
Contributor
Author
|
i was surprised by the drift in runtime-deps.txt, @RussellSpitzer wydt about this pattern to autoupdate for dependabot? |
Member
|
@kevinjqliu Ryan and I discussed this in the previous work. Rather than letting dependapot automatically change the deps (or raise the change) we just decided to ignore patch updates. I still record them though so it may make sense to remove them |
Member
|
I think I would vote that we just drop the patch's from the dependency text to avoid the churn there. |
kevinjqliu
force-pushed
the
kevinjqliu/strict-runtime-deps
branch
from
430ab99 to
9bbf0b9
Compare
kevinjqliu
changed the title
kevinjqliu
force-pushed
the
kevinjqliu/strict-runtime-deps
branch
from
d9426bd to
7ce9c66
Compare
Contributor
Author
i like that more, made the change |
kevinjqliu
force-pushed
the
kevinjqliu/strict-runtime-deps
branch
from
7ce9c66 to
5bd85d8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR changes
checkRuntimeDepsto store onlymajor.minorinruntime-deps.txtfiles.Previously,
runtime-deps.txtstored fullmajor.minor.patchversions butcheckRuntimeDepsonly flagged mismatches at themajor.minorlevel. This allowed Dependabot patch bumps (e.g.5.6.0 → 5.6.1) to pass CI without updating the baseline, but over time the baselines drifted from the actual resolved dependencies, causing PRs like #16204 to merge with stale baselines.By storing only
major.minorin the baseline, bothgenerateRuntimeDepsandcheckRuntimeDepsnow operate on the same coordinates. Patch bumps produce identical entries so Dependabot PRs pass freely, while major/minor changes, added deps, and removed deps still fail the check.Testing